Skip to content

Switch NuGet publish workflow to trusted publishing - #137

Merged
wforney merged 1 commit into
mainfrom
copilot/update-nuget-publish-step
Aug 13, 2026
Merged

Switch NuGet publish workflow to trusted publishing#137
wforney merged 1 commit into
mainfrom
copilot/update-nuget-publish-step

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The release workflow still published to nuget.org with a long-lived API key secret. This updates the NuGet publish job to use GitHub OIDC trusted publishing and a short-lived credential issued at runtime.

  • What changed

    • Added id-token: write to the nuget-publish job so GitHub Actions can request an OIDC token for nuget.org.
    • Added NuGet/login@v1 to exchange the OIDC token for a temporary NuGet API key.
    • Replaced the static NUGET_API_KEY secret in dotnet nuget push with the ephemeral key from the login step.
  • Workflow impact

    • NuGet publishing no longer depends on a stored API key secret.
    • The job now aligns with nuget.org trusted publishing requirements and uses repository/workflow identity instead of a shared credential.
  • Updated publish path

    permissions:
      contents: read
      id-token: write
    
    - name: Authenticate with NuGet.org
      id: login
      uses: NuGet/login@v1
      with:
        user: ${{ secrets.NUGET_USER }}
    
    - name: Push Package to NuGet
      run: dotnet nuget push --api-key ${{ steps.login.outputs.NUGET_API_KEY }} --source "https://api.nuget.org/v3/index.json" *.nupkg

@wforney
wforney marked this pull request as ready for review August 13, 2026 09:09
Copilot AI lite review requested due to automatic review settings August 13, 2026 09:09
@github-actions

Copy link
Copy Markdown

Summary

Summary
Generated on: 8/13/2026 - 9:13:37 AM
Parser: Cobertura
Assemblies: 4
Classes: 195
Files: 158
Line coverage: 42.4% (3213 of 7567)
Covered lines: 3213
Uncovered lines: 4354
Coverable lines: 7567
Total lines: 19611
Branch coverage: 25.1% (1087 of 4324)
Covered branches: 1087
Total branches: 4324
Method coverage: Feature is only available for sponsors

Coverage

SharedCode.Core - 27.3%
Name Line Branch
SharedCode.Core 27.3% 24.8%
SharedCode.AssemblyExtensions 100% 100%
SharedCode.Attributes.DataFormatAttribute 100% 100%
SharedCode.Attributes.DataWidthAttribute 100% 100%
SharedCode.Attributes.StringValueAttribute 100% 100%
SharedCode.BaseException 100% 50%
SharedCode.Calendar.DateTimeExtensions 10.8% 0.7%
SharedCode.Calendar.DateTimeOffsetExtensions 70.3% 44.2%
SharedCode.Calendar.DayOfWeekExtensions 90.9% 87.5%
SharedCode.Collections.ArrayExtensions 92% 73.3%
SharedCode.Collections.Generic.EnumerableExtensions 0% 0%
SharedCode.Collections.Generic.EnumerableExtensions 0% 0%
SharedCode.Collections.Generic.EnumerationUtilities 100%
SharedCode.Collections.ListExtensions 14.2% 12.5%
SharedCode.Collections.ObservableCollectionExtensions 0% 0%
SharedCode.Data.DataReaderExtensions 0% 0%
SharedCode.Data.DataRowExtensions 0% 0%
SharedCode.Data.DataTableExtensions 0% 0%
SharedCode.DateTimeExtensions 0% 0%
SharedCode.DateTimeOffsetExtensions 0% 0%
SharedCode.Domain.Error 88.8%
SharedCode.Domain.ErrorResult 90.9% 100%
SharedCode.Domain.ErrorResult 72.7% 50%
SharedCode.Domain.HttpErrorResult 50%
SharedCode.Domain.Result 100%
SharedCode.Domain.Result 88.8%
SharedCode.Domain.ValidationError 75%
SharedCode.Domain.ValidationErrorResult 80%
SharedCode.Enum 93.2% 83.9%
SharedCode.Enum 50%
SharedCode.EnumExtensions 100%
SharedCode.EventArgs 100%
SharedCode.EventHandlerExtensions 75% 75%
SharedCode.Events.DomainEvent 0%
SharedCode.ExceptionExtensions 51% 32.7%
SharedCode.Extensions 23.6% 14.4%
SharedCode.Extensions 23.6% 14.4%
SharedCode.FluentTimeSpan 66.2% 71.4%
SharedCode.FunctionExtensions 100% 83.3%
SharedCode.FunctionExtensions<T, TResult> 100% 83.3%
SharedCode.IntExtensions 100% 100%
SharedCode.IO.BufferedWriter 0% 0%
SharedCode.IO.DirectoryInfoExtensions 0% 0%
SharedCode.IO.FileInfoExtensions 0% 0%
SharedCode.IO.StreamExtensions 0% 0%
SharedCode.IO.TcpClientExtensions 0% 0%
SharedCode.Linq.CollectionExtensions 59.3% 52.3%
SharedCode.Linq.CollectionExtensions.SyncChanges 0%
SharedCode.Linq.CollectionExtensions<T, TKey> 59.3% 52.3%
SharedCode.Linq.CollectionExtensions 59.3% 52.3%
SharedCode.Linq.EnumerableExtensions 32.7% 26.1%
SharedCode.Linq.EnumerableExtensions<T, TKey> 32.7% 26.1%
SharedCode.Linq.EnumerableExtensions<T, TResult> 32.7% 26.1%
SharedCode.Linq.EnumerableExtensions 32.7% 26.1%
SharedCode.Linq.EnumerableExtensions<TKey, TValue> 32.7% 26.1%
SharedCode.Linq.EnumeratorExtensions 0% 0%
SharedCode.Linq.ExpressionExtensions 0% 0%
SharedCode.Linq.PredicateBuilder 0% 0%
SharedCode.Linq.Predicates 100% 100%
SharedCode.Linq.QueryableExtensions 0%
SharedCode.Linq.QueryableExtensions 0%
SharedCode.Models.Entity 100%
SharedCode.Models.Entity 75% 75%
SharedCode.Notifications.Notification 0% 0%
SharedCode.Notifications.NotificationService 0% 0%
SharedCode.Notifications.ObservableExtensions 0% 0%
SharedCode.Notifications.ObservableExtensions 0% 0%
SharedCode.Notifications.ProducerConsumer 0% 0%
SharedCode.NumberExtensions 100%
SharedCode.Problems.Problem 0% 0%
SharedCode.Problems.ProblemConstants.Types 0%
SharedCode.Problems.ProblemCreationExtensions 0%
SharedCode.Problems.ProblemException 0% 0%
SharedCode.Problems.ProblemJsonConverter 0% 0%
SharedCode.PropertySupport 83.3% 60%
SharedCode.Reflection.DeepCloneCache 0% 0%
SharedCode.Reflection.DeepCloneCache 0% 0%
SharedCode.Reflection.DeepCloneExpressionGenerator 0% 0%
SharedCode.Reflection.DeepCloneGenerator 0% 0%
SharedCode.Reflection.DeepCloneGenerator 0% 0%
SharedCode.Reflection.DeepCloneMsilHelper 0% 0%
SharedCode.Reflection.DeepCloneSafeTypes 0% 0%
SharedCode.Reflection.DeepCloneState 0% 0%
SharedCode.Reflection.DeepCloneState.MiniDictionary 0% 0%
SharedCode.Reflection.ExpressionGenerator 0% 0%
SharedCode.Reflection.GenericExtensions 0% 0%
SharedCode.Reflection.ShallowCloneGenerator 0% 0%
SharedCode.Reflection.ShallowCloneHelper 0% 0%
SharedCode.Reflection.ShallowCloneHelper.ShallowSafeObjectCloneHelper 0%
SharedCode.Security.Hasher 38.6% 44.4%
SharedCode.Specifications.Builders.CacheSpecificationBuilder 50%
SharedCode.Specifications.Builders.IncludableBuilderExtensions 0% 0%
SharedCode.Specifications.Builders.IncludableSpecificationBuilder<T, TPrope
rty>
50%
SharedCode.Specifications.Builders.OrderedBuilderExtensions 50% 25%
SharedCode.Specifications.Builders.OrderedSpecificationBuilder 100%
SharedCode.Specifications.Builders.SpecificationBuilder<T, TResult> 100%
SharedCode.Specifications.Builders.SpecificationBuilder 100%
SharedCode.Specifications.Builders.SpecificationBuilderExtensions 100% 58.3%
SharedCode.Specifications.Evaluators.InMemorySpecificationEvaluator 96.2% 78.5%
SharedCode.Specifications.Evaluators.OrderEvaluator 45.9% 36.2%
SharedCode.Specifications.Evaluators.OrderEvaluator 45.9% 36.2%
SharedCode.Specifications.Evaluators.PaginationEvaluator 50% 37.5%
SharedCode.Specifications.Evaluators.WhereEvaluator 66.6% 37.5%
SharedCode.Specifications.Exceptions.DuplicateOrderChainException 0%
SharedCode.Specifications.Exceptions.DuplicateSkipException 25%
SharedCode.Specifications.Exceptions.DuplicateTakeException 25%
SharedCode.Specifications.Exceptions.SelectorNotFoundException 25%
SharedCode.Specifications.IncludeExpressionInformation 69.2% 40%
SharedCode.Specifications.Specification<T, TResult> 100%
SharedCode.Specifications.Specification 100%
SharedCode.Text.StringBuilderExtensions 100% 100%
SharedCode.Text.StringExtensions 28.3% 28.9%
SharedCode.Text.StringExtensions 28.3% 28.9%
SharedCode.Threading.Tasks.TaskExtensions 92.8%
SharedCode.Threading.Tasks.TaskExtensions 92.8%
SharedCode.Threading.Tasks.ValueTaskExtensions 0%
SharedCode.Threading.Tasks.ValueTaskExtensions<TException, TResult> 0%
SharedCode.Threading.Tasks.ValueTaskExtensions 0%
SharedCode.Threading.Tasks.ValueTaskExtensions 0%
SharedCode.TypeExtensions 33.3% 36%
SharedCode.TypeExtensions 33.3% 36%
SharedCode.Utilities 0% 0%
SharedCode.ValueObject 80% 90.9%
SharedCode.Workflow.Rule 0%
SharedCode.Workflow.Rule 0%
SharedCode.Workflow.RuleSet 0%
SharedCode.Workflow.RuleSet 0%
SharedCode.Xml.XDocumentExtensions 0% 0%
System.Text.RegularExpressions.Generated 0% 0%
System.Text.RegularExpressions.Generated.RunnerFactory
System.Text.RegularExpressions.Generated.RunnerFactory.Runner
SharedCode.Core.Tests - 98.1%
Name Line Branch
SharedCode.Core.Tests 98.1% 77.4%
SharedCode.Tests.AssemblyExtensionsTests 100%
SharedCode.Tests.AssertExtensions 0% 0%
SharedCode.Tests.Attributes.AttributeTests 100% 100%
SharedCode.Tests.BaseExceptionTests 100%
SharedCode.Tests.Calendar.DateTimeExtensionsTests 96.3% 100%
SharedCode.Tests.Calendar.DateTimeOffsetCalendarExtensionsTests 100%
SharedCode.Tests.Calendar.DayOfWeekExtensionsTests 100%
SharedCode.Tests.Collections.ArrayExtensionsTests 100% 100%
SharedCode.Tests.Collections.EnumerationUtilitiesTests 100%
SharedCode.Tests.Domain.ErrorResultTests 100%
SharedCode.Tests.Domain.ResultTests 100%
SharedCode.Tests.EnumExtensionsTests 100%
SharedCode.Tests.EnumTTests 96.2% 90%
SharedCode.Tests.EventHandlerExtensionsTests 100%
SharedCode.Tests.ExceptionExtensionsTests 100%
SharedCode.Tests.ExtensionsTests 100% 100%
SharedCode.Tests.ExtensionsTests.SampleRecord 100%
SharedCode.Tests.FluentTimeSpanTests 100%
SharedCode.Tests.FunctionExtensionsTests 100%
SharedCode.Tests.IntExtensionsTests 100%
SharedCode.Tests.LambdaComparer 0% 0%
SharedCode.Tests.Linq.CollectionExtensionsTests 100% 100%
SharedCode.Tests.Linq.EnumerableExtensionsTests 100% 100%
SharedCode.Tests.Linq.PredicatesTests 100%
SharedCode.Tests.Models.EntityTests 100%
SharedCode.Tests.NumberExtensionsTests 100%
SharedCode.Tests.PropertySupportTests 100% 100%
SharedCode.Tests.PropertySupportTests.SampleClass 100%
SharedCode.Tests.Security.HasherTests 100%
SharedCode.Tests.Specifications.SpecificationTests 97.7% 100%
SharedCode.Tests.Specifications.SpecificationTests.BuilderExposingSpecifica
tion
100%
SharedCode.Tests.Specifications.SpecificationTests.DuplicateSkipSpecificati
on
66.6%
SharedCode.Tests.Specifications.SpecificationTests.DuplicateTakeSpecificati
on
66.6%
SharedCode.Tests.Specifications.SpecificationTests.SampleEntity 100%
SharedCode.Tests.Specifications.SpecificationTests.SampleEntitySpecificatio
n
100% 100%
SharedCode.Tests.Specifications.SpecificationTests.SampleProjectionSpecific
ation
100% 100%
SharedCode.Tests.Specifications.SpecificationTests.SearchOnlySpecification 100%
SharedCode.Tests.Text.StringBuilderExtensionsTests 100%
SharedCode.Tests.Text.StringExtensionsTests 100% 100%
SharedCode.Tests.Threading.TaskExtensionsTests 100%
SharedCode.Tests.TypeExtensionsTests 100%
SharedCode.Tests.ValueObjectTests 96.8%
SharedCode.Tests.ValueObjectTests.Address 66.6%
SharedCode.Tests.ValueObjectTests.MoneyValue 100%
TUnit.Generated.Hooks.SharedCode_Tests_Calendar_DateTimeExtensionsTests_Ini
tTestCase_Before_Test.SharedCode_Tests_Calendar_DateTimeExtensionsTests_Ini
tTestCase_Before_TestInitializer
100%
TUnit.Generated.Hooks.SharedCode_Tests_Calendar_DateTimeExtensionsTests_Tea
rdownTestCase_After_Test.SharedCode_Tests_Calendar_DateTimeExtensionsTests_
TeardownTestCase_After_TestInitializer
100%
SharedCode.Data - 8.3%
Name Line Branch
SharedCode.Data 8.3% 0%
SharedCode.Data.AddOrUpdateDescriptor 0%
SharedCode.Data.CommandRepository 0% 0%
SharedCode.Data.DataReaderExtensions 0% 0%
SharedCode.Data.DataReaderExtensions 0% 0%
SharedCode.Data.DataRecordConverter 0% 0%
SharedCode.Data.DataServiceQueryExtensions 0% 0%
SharedCode.Data.DataServiceQueryExtensions 0% 0%
SharedCode.Data.DataServiceQueryExtensions 0% 0%
SharedCode.Data.DynamicDataRecord 0% 0%
SharedCode.Data.Exceptions.ColumnIsNotInResultSetException 0%
SharedCode.Data.Extensions 0% 0%
SharedCode.Data.ListExtensions 0% 0%
SharedCode.Data.PageBoundry 100%
SharedCode.Data.PagingDescriptor 100%
SharedCode.Data.QueryRepository 0% 0%
SharedCode.Data.QueryResult 100%
SharedCode.Data.Tests - 100%
Name Line Branch
SharedCode.Data.Tests 100% ****
SharedCode.Data.Tests.PageBoundryTests 100%
SharedCode.Data.Tests.PagingDescriptorTests 100%
SharedCode.Data.Tests.QueryResultTests 100%

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow to publish NuGet packages to nuget.org using GitHub OIDC trusted publishing, replacing the prior long-lived NuGet API key secret approach.

Changes:

  • Grants the nuget-publish job id-token: write so it can request an OIDC token at runtime.
  • Adds NuGet/login@v1 to exchange the OIDC token for a short-lived NuGet API key.
  • Updates dotnet nuget push to use the ephemeral API key output from the login step.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wforney
wforney merged commit 99f550d into main Aug 13, 2026
14 checks passed
@wforney
wforney deleted the copilot/update-nuget-publish-step branch August 13, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants